Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM: enable System.ObjectModel.Tests #39849

Merged
merged 1 commit into from
Jul 23, 2020
Merged

WASM: enable System.ObjectModel.Tests #39849

merged 1 commit into from
Jul 23, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jul 23, 2020

Contributes towards: #38422

@safern safern requested review from steveisok and akoeplinger July 23, 2020 18:52
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@steveisok steveisok mentioned this pull request Jul 23, 2020
Closed
99 tasks
@jaredpar jaredpar mentioned this pull request Jul 23, 2020
Closed
@SamMonoRT
Copy link
Member

Straightforward change, LGTM !

@safern safern merged commit 4ac596d into dotnet:master Jul 23, 2020
@safern safern deleted the wasm-enablesystemobjectmodel branch July 23, 2020 22:05
akoeplinger
akoeplinger reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@safern @Jacksondr5
WASM: enable System.ObjectModel.Tests (dotnet#39849)
59bbd92
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

@steveisok steveisok Awaiting requested review from steveisok

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@safern @Dotnet-GitSync-Bot @SamMonoRT @akoeplinger @karelz @maryamariyan